DOCS-758 Adds new commit scope rule degradation functionality for synchronous and group commit. #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpe442
changed the title
jpe442
changed the title
josh-heyer
force-pushed
the
DOCS-978-Full-Branch-5.6
branch
2 times, most recently
from
004687d
to
d9e248d
Compare
josh-heyer
force-pushed
the
DOCS-758
branch
from
59bace1
to
f94c311
Compare
jpe442
added
the
deploy
djw-m
reviewed
Sep 18, 2024
djw-m
reviewed
Sep 18, 2024
There was a problem hiding this comment.
This feels like it is missing a "Degrade options" entry under commit scopes which explains what the DEGRADE ON clause does and which commands support it.
Also the reordering should be applies to the commit scope rules section... whatever order that will be...
josh-heyer
force-pushed
the
DOCS-978-Full-Branch-5.6
branch
from
f3a615c
to
6a4788c
Compare
josh-heyer
force-pushed
the
DOCS-758
branch
from
c3b551c
to
1755255
Compare
|
⚠Rebased! Pull latest before continuing work. |
Got it. Added Degrade options section and made reordering consistent throughout. |
djw-m
reviewed
Sep 23, 2024
djw-m
reviewed
Sep 23, 2024
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
djw-m
reviewed
Oct 8, 2024
djw-m
approved these changes
Oct 8, 2024
| - '# Commit Scope kinds' | ||
| - synchronous_commit |
There was a problem hiding this comment.
Not sure why synchronous_commit is being pushed ahead of group commit. Group commit, synchronous commit, camo and then lag control (by use/feature maturity?)
Co-authored-by: Dj Walker-Morgan <[email protected]>
djw-m
added a commit
that referenced
this pull request
Oct 15, 2024
…chronous and group commit. (#6044) * First draft reference changes. * Small changes. * Small tweaks. * More small changes in group and synchrnounous commit. * Small fixes. * More small tweaks. * tried to fix link. * Changing paths to absolute. * Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/index.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Changed wording in Group commit. * Changed order of commit scopes in Commit scope rules to feature synchronous commit first. * changed overview to put synch commit before group commit. * Removed some white space. * Degrade options section. * Added Degrade on section in Commit scopes page. * Fixed some small things. * Small word change. * Move CAMO and adjust accordingly. * Small changes. * Moved degrading options to its own page. * Addressed one of DJ's comments. * Update product_docs/docs/pgd/5.6/commit-scopes/degrading.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/degrading.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/degrading.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/reference/commit-scopes.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/reference/commit-scopes.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Moved behavior section up. * Worked on wording given Petr's comments. * More word changes. * Add degrading bit to Overview. * Added wrap-language support, wrapped blocks, added degrading to index Signed-off-by: Dj Walker-Morgan <[email protected]> * Remove console.log hangover Signed-off-by: Dj Walker-Morgan <[email protected]> * Improve feedback Signed-off-by: Dj Walker-Morgan <[email protected]> * Shorten tooltip Signed-off-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/degrading.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/group-commit.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/index.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Update product_docs/docs/pgd/5.6/commit-scopes/degrading.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> * Disable startWrap for now Signed-off-by: Dj Walker-Morgan <[email protected]> * Fix link. * Update product_docs/docs/pgd/5.6/commit-scopes/commit-scope-rules.mdx Co-authored-by: Dj Walker-Morgan <[email protected]> --------- Signed-off-by: Dj Walker-Morgan <[email protected]> Co-authored-by: Dj Walker-Morgan <[email protected]> Co-authored-by: Dj Walker-Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Adds new commit scope operation degradation functionality for synchronous commit and group commit. Affects both commit scope reference section and commit scopes feature section in PGD docs.
Tracked here in DOCS-758.